yihua commented on code in PR #8326:
URL: https://github.com/apache/hudi/pull/8326#discussion_r1155029276
##########
hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java:
##########
@@ -149,7 +150,7 @@ protected boolean needUpdatingPersistedRecord(IndexedRecord
currentValue,
* NOTE: Deletes sent via EmptyHoodieRecordPayload and/or Delete operation
type do not hit this code path
* and need to be dealt with separately.
*/
- String orderField =
properties.getProperty(HoodiePayloadProps.PAYLOAD_ORDERING_FIELD_PROP_KEY);
+ String orderField = ConfigUtils.getOrderingField(properties);
Review Comment:
Could you add tests for these two changes, i.e., if the payload ordering
field is not set but the pre-combine field is set? Check
`TestDefaultHoodieRecordPayload` class for how to write a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
