yihua commented on code in PR #8238:
URL: https://github.com/apache/hudi/pull/8238#discussion_r1155055932
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCleanConfig.java:
##########
@@ -59,25 +63,67 @@ public class HoodieCleanConfig extends HoodieConfig {
.withDocumentation("Only applies when " + AUTO_CLEAN.key() + " is turned
on. "
+ "When turned on runs cleaner async with writing, which can speed
up overall write performance.");
+ // The cleaner policy config definition has to be before the following
configs for inference:
+ // CLEANER_COMMITS_RETAINED, CLEANER_HOURS_RETAINED,
CLEANER_FILE_VERSIONS_RETAINED
+ public static final ConfigProperty<String> CLEANER_POLICY = ConfigProperty
+ .key("hoodie.cleaner.policy")
+ .defaultValue(HoodieCleaningPolicy.KEEP_LATEST_COMMITS.name())
+ .withInferFunction(cfg -> {
+ boolean isCommitsRetainedConfigured =
cfg.contains(CLEANER_COMMITS_RETAINED_KEY);
+ boolean isHoursRetainedConfigured =
cfg.contains(CLEANER_HOURS_RETAINED_KEY);
Review Comment:
As discussed, I marked it as deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
