nsivabalan commented on code in PR #8345:
URL: https://github.com/apache/hudi/pull/8345#discussion_r1155542372
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java:
##########
@@ -225,26 +225,24 @@ private Comparable[] commitDetail(GenericRecord record,
String metadataName,
}
private Comparable[] readCommit(GenericRecord record, boolean skipMetadata) {
- try {
- switch (record.get("actionType").toString()) {
- case HoodieTimeline.CLEAN_ACTION:
- return commitDetail(record, "hoodieCleanMetadata", skipMetadata);
- case HoodieTimeline.COMMIT_ACTION:
- case HoodieTimeline.DELTA_COMMIT_ACTION:
- return commitDetail(record, "hoodieCommitMetadata", skipMetadata);
- case HoodieTimeline.ROLLBACK_ACTION:
- return commitDetail(record, "hoodieRollbackMetadata", skipMetadata);
- case HoodieTimeline.SAVEPOINT_ACTION:
- return commitDetail(record, "hoodieSavePointMetadata", skipMetadata);
- case HoodieTimeline.COMPACTION_ACTION:
- return commitDetail(record, "hoodieCompactionMetadata",
skipMetadata);
- default: {
- return new Comparable[] {};
- }
+ String actionType = record.get("actionType").toString();
+ switch (actionType) {
+ case HoodieTimeline.CLEAN_ACTION:
+ return commitDetail(record, "hoodieCleanMetadata", skipMetadata);
+ case HoodieTimeline.COMMIT_ACTION:
+ case HoodieTimeline.DELTA_COMMIT_ACTION:
+ return commitDetail(record, "hoodieCommitMetadata", skipMetadata);
+ case HoodieTimeline.ROLLBACK_ACTION:
+ return commitDetail(record, "hoodieRollbackMetadata", skipMetadata);
+ case HoodieTimeline.SAVEPOINT_ACTION:
+ return commitDetail(record, "hoodieSavePointMetadata", skipMetadata);
+ case HoodieTimeline.COMPACTION_ACTION:
+ return commitDetail(record, "hoodieCompactionMetadata", skipMetadata);
+ case HoodieTimeline.REPLACE_COMMIT_ACTION:
+ return commitDetail(record, "hoodieReplaceCommitMetadata",
skipMetadata);
+ default: {
Review Comment:
how about restore, log compaction, indexing actions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
