This is an automated email from the ASF dual-hosted git repository.
vbalaji pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new 1a9fef4 Fixing binary file checks and disclaimer file checks (#1691)
1a9fef4 is described below
commit 1a9fef48e767c2bb56b9fba5cac48540c5d6c6c1
Author: Sivabalan Narayanan <[email protected]>
AuthorDate: Sat May 30 23:09:21 2020 -0400
Fixing binary file checks and disclaimer file checks (#1691)
---
scripts/release/validate_staged_release.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/release/validate_staged_release.sh
b/scripts/release/validate_staged_release.sh
index ed05041..72e2e4c 100755
--- a/scripts/release/validate_staged_release.sh
+++ b/scripts/release/validate_staged_release.sh
@@ -97,11 +97,11 @@ cd hudi-${RELEASE_VERSION}-rc${RC_NUM}
### BEGIN: Binary Files Check
echo "Checking for binary files in source release"
-numBinaryFiles=`find . -iname '*' | xargs -I {} file -I {} | grep -va
directory | grep -va 'text/' | grep -va 'application/xml' | grep -va
'application/json' | wc -l | sed -e s'/ //g'`
+numBinaryFiles=`find . -iname '*' | xargs -I {} file -I {} | grep -va
directory | grep -va 'application/json' | grep -va 'text/' | grep -va
'application/xml' | grep -va 'application/json' | wc -l | sed -e s'/ //g'`
if [ "$numBinaryFiles" -gt "0" ]; then
echo -e "There were non-text files in source release. Please check below\n"
- find . -iname '*' | xargs -I {} file -I {} | grep -va directory | grep -va
'text/' | grep -va 'application/xml'
+ find . -iname '*' | xargs -I {} file -I {} | grep -va directory | grep -va
'application/json' | grep -va 'text/' | grep -va 'application/xml'
exit -1
fi
echo -e "\t\tNo Binary Files in Source Release? - [OK]\n"
@@ -110,8 +110,8 @@ echo -e "\t\tNo Binary Files in Source Release? - [OK]\n"
### Checking for DISCLAIMER
echo "Checking for DISCLAIMER"
disclaimerFile="./DISCLAIMER"
-if [ ! -f "$disclaimerFile" ]; then
- echo "DISCLAIMER file missing"
+if [ -f "$disclaimerFile" ]; then
+ echo "DISCLAIMER file should not be present "
exit -1
fi
echo -e "\t\tDISCLAIMER file exists ? [OK]\n"