LinMingQiang commented on code in PR #8338:
URL: https://github.com/apache/hudi/pull/8338#discussion_r1155829734
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -217,18 +218,52 @@ public static HoodieTableMetaClient initTableIfNotExists(
.setCDCEnabled(conf.getBoolean(FlinkOptions.CDC_ENABLED))
.setCDCSupplementalLoggingMode(conf.getString(FlinkOptions.SUPPLEMENTAL_LOGGING_MODE))
.setTimelineLayoutVersion(1)
+ .setHoodieIndexConf(OptionsResolver.getHoodieIndexConf(conf))
.initTable(hadoopConf, basePath);
LOG.info("Table initialized under base path {}", basePath);
return metaClient;
} else {
LOG.info("Table [{}/{}] already exists, no need to initialize the table",
basePath, conf.getString(FlinkOptions.TABLE_NAME));
- return StreamerUtil.createMetaClient(basePath, hadoopConf);
+ HoodieTableMetaClient client = StreamerUtil.createMetaClient(basePath,
hadoopConf);
+ validateTableConfig(conf, client.getTableConfig());
Review Comment:
from my perspective, i think it can be promoted.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -217,18 +218,52 @@ public static HoodieTableMetaClient initTableIfNotExists(
.setCDCEnabled(conf.getBoolean(FlinkOptions.CDC_ENABLED))
.setCDCSupplementalLoggingMode(conf.getString(FlinkOptions.SUPPLEMENTAL_LOGGING_MODE))
.setTimelineLayoutVersion(1)
+ .setHoodieIndexConf(OptionsResolver.getHoodieIndexConf(conf))
.initTable(hadoopConf, basePath);
LOG.info("Table initialized under base path {}", basePath);
return metaClient;
} else {
LOG.info("Table [{}/{}] already exists, no need to initialize the table",
basePath, conf.getString(FlinkOptions.TABLE_NAME));
- return StreamerUtil.createMetaClient(basePath, hadoopConf);
+ HoodieTableMetaClient client = StreamerUtil.createMetaClient(basePath,
hadoopConf);
+ validateTableConfig(conf, client.getTableConfig());
Review Comment:
From my perspective, i think it can be promoted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
