bvaradar commented on code in PR #6799:
URL: https://github.com/apache/hudi/pull/6799#discussion_r1156663626
##########
hudi-common/src/test/java/org/apache/hudi/common/model/TestPartialUpdateAvroPayload.java:
##########
@@ -155,8 +155,8 @@ public void testDeletedRecord() throws IOException {
PartialUpdateAvroPayload payload1 = new PartialUpdateAvroPayload(record1,
0L);
PartialUpdateAvroPayload payload2 = new
PartialUpdateAvroPayload(delRecord1, 1L);
- assertArrayEquals(payload1.preCombine(payload2).recordBytes,
payload2.recordBytes);
- assertArrayEquals(payload2.preCombine(payload1).recordBytes,
payload2.recordBytes);
+ assertArrayEquals(payload1.preCombine(payload2, schema, new
Properties()).recordBytes, payload2.recordBytes);
+ assertArrayEquals(payload2.preCombine(payload1, schema, new
Properties()).recordBytes, payload2.recordBytes);
Review Comment:
Can you add an explicit test-case for deleted record case here during
precombine. The test-case needs to check for _hoodie_is_deleted flag in the
returned record.
##########
hudi-common/src/main/java/org/apache/hudi/common/model/PartialUpdateAvroPayload.java:
##########
@@ -89,6 +89,8 @@
*/
public class PartialUpdateAvroPayload extends
OverwriteNonDefaultsWithLatestAvroPayload {
+ private boolean isPreCombining = false;
Review Comment:
This member variable needs to be removed as this is no longer used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
