yihua commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1159102731
##########
hudi-aws/src/main/java/org/apache/hudi/config/DynamoDbBasedLockConfig.java:
##########
@@ -46,7 +46,7 @@ public class DynamoDbBasedLockConfig extends HoodieConfig {
public static final ConfigProperty<String> DYNAMODB_LOCK_TABLE_NAME =
ConfigProperty
.key(DYNAMODB_BASED_LOCK_PROPERTY_PREFIX + "table")
- .noDefaultValue()
+ .defaultValue("hudi_locks")
Review Comment:
The lock for the same table is identified by the
`DYNAMODB_LOCK_PARTITION_KEY` config. This is the DynamoDB table to use. It
can be shared across tables.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
- // by default, the HFile does not keep the metadata fields, set up
as false
- // to always use the metadata of the new record.
- .withPreserveCommitMetadata(false)
Review Comment:
@lokeshj1703 This is ok, though we actually don't need the differentiating
logic for metadata table and it can be set to `true`, given that MDT does not
have the meta fields and there is no difference in logic between setting it to
`true` and `false`. I'm going to land this PR now. Let's put up a separate PR
to clean it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
