xiarixiaoyao commented on PR #8380: URL: https://github.com/apache/hudi/pull/8380#issuecomment-1499073740
> @xiarixiaoyao > > For conversions that loses accuracy, this really depends on the data that's in the table. > > I do not think a check on all existing data is feasible. i.e. checking all existing data to ensure that there is no loss in accuracy, and if there is one, we will need to throw an exception to prevent the `ALTER TABLE CHANGE COLUMN TYPE` DDL to fail. > > IIUC, the only time we can perform this check is when we are doing the ALTER TABLE DDL as a DECIMAL -> float/double schema change (reversing whatever is done) is not allowed. > > As such, I believe we will need to document this potential loss in accuracy to remind users of such a behaviour. doc +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
