codope commented on code in PR #8448:
URL: https://github.com/apache/hudi/pull/8448#discussion_r1165043872
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/HoodieBloomIndex.java:
##########
@@ -234,8 +234,8 @@ protected List<Pair<String, BloomIndexFileInfo>>
loadColumnRangesFromMetaIndex(
new BloomIndexFileInfo(
FSUtils.getFileId(entry.getKey().getRight()),
// NOTE: Here we assume that the type of the primary key field
is string
- (String)
unwrapStatisticValueWrapper(entry.getValue().getMinValue()),
- (String)
unwrapStatisticValueWrapper(entry.getValue().getMaxValue())
+
unwrapStatisticValueWrapper(entry.getValue().getMinValue()).toString(),
+
unwrapStatisticValueWrapper(entry.getValue().getMaxValue()).toString()
Review Comment:
Could potentially result in `null` dereference.
Also, we have made a note of the assumption that primary key is supposed to
be string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
