danny0405 commented on code in PR #8418: URL: https://github.com/apache/hudi/pull/8418#discussion_r1168230208
########## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetRowDataWriter.java: ########## @@ -31,6 +31,7 @@ import org.apache.flink.table.types.logical.RowType; import org.apache.flink.table.types.logical.TimestampType; import org.apache.flink.util.Preconditions; +import org.apache.hudi.common.util.ValidationUtils; import org.apache.parquet.io.api.Binary; Review Comment: org.apache.hudi package should be alway in the highest import sequence, you many need to import the checkstyle from the file: https://github.com/apache/hudi/blob/d9b29e540314f842d8d3aa86f8429cca8a8cf786/style/checkstyle.xml#L291 ########## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetRowDataWriter.java: ########## @@ -31,6 +31,7 @@ import org.apache.flink.table.types.logical.RowType; import org.apache.flink.table.types.logical.TimestampType; import org.apache.flink.util.Preconditions; +import org.apache.hudi.common.util.ValidationUtils; import org.apache.parquet.io.api.Binary; Review Comment: org.apache.hudi package should be always in the highest import sequence, you many need to import the checkstyle from the file: https://github.com/apache/hudi/blob/d9b29e540314f842d8d3aa86f8429cca8a8cf786/style/checkstyle.xml#L291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
