kwondw opened a new pull request #1703:
URL: https://github.com/apache/hudi/pull/1703


   ## What is the purpose of the pull request
   
   For Delete API, I noticed "hoodie.delete.shuffle.parallelism" isn't used as 
opposed to "hoodie.upsert.shuffle.parallelism" is used for 
[upsert](https://github.com/apache/hudi/blob/master/hudi-client/src/main/java/org/apache/hudi/table/action/commit/WriteHelper.java#L104),
 this creates the performance difference between delete by upsert API with 
"EmptyHoodieRecordPayload" and delete API for certain cases.
   
   https://issues.apache.org/jira/browse/HUDI-993 has more detail.
   
   ## Brief change log
   
   * Let 
[deduplicateKeys](https://github.com/apache/hudi/blob/master/hudi-client/src/main/java/org/apache/hudi/table/action/commit/DeleteHelper.java#L51-L57)
 method use "hoodie.upsert.shuffle.parallelism"
   * Repartition inputRDD as "hoodie.upsert.shuffle.parallelism" in case 
"hoodie.combine.before.delete=false"
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
   ## Committer checklist
   
    - [X] Has a corresponding JIRA in PR title & commit
    
    - [X] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [X] Necessary doc changes done or have another open PR
          
    - [X] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to