rahil-c commented on code in PR #8441:
URL: https://github.com/apache/hudi/pull/8441#discussion_r1171936527
##########
hudi-aws/src/main/java/org/apache/hudi/aws/cloudwatch/CloudWatchReporter.java:
##########
@@ -169,9 +168,9 @@ protected CloudWatchReporter(MetricRegistry registry,
this.maxDatumsPerRequest = maxDatumsPerRequest;
}
- private static AmazonCloudWatchAsync getAmazonCloudWatchClient(Properties
props) {
- return AmazonCloudWatchAsyncClientBuilder.standard()
-
.withCredentials(HoodieAWSCredentialsProviderFactory.getAwsCredentialsProvider(props))
+ private static CloudWatchAsyncClient getAmazonCloudWatchClient(Properties
props) {
+ return CloudWatchAsyncClient.builder()
Review Comment:
https://github.com/aws/aws-sdk-java-v2/blob/master/docs/LaunchChangelog.md#4-service-changes.
If you look at the table for several of these aws clients the table shows a
before column where the .standard was used in 1.x and now in 2.x it is replaced
by using the `.builder` pattern. See this snippet taken from link above
```
Client builders no longer contain static methods. The static methods on the
clients must be used: AmazonDynamoDBClientBuilder.defaultClient is now
DynamoDbClient.create and AmazonDynamoDBClientBuilder.standard is now
DynamoDbClient.builder.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
