Zouxxyy commented on code in PR #8488:
URL: https://github.com/apache/hudi/pull/8488#discussion_r1172047050
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +40,12 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = metaClient.getTableConfig.getDatabaseName match {
+ case databaseName: String => databaseName + "." +
metaClient.getTableConfig.getTableName
+ case _ => metaClient.getTableConfig.getTableName
+ }
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession,
metaClient.getTableConfig.getTableName)) ++ conf)
+ buildHoodieConfig(getHoodieCatalogTable(sparkSession, table)) ++ conf)
Review Comment:
@XuQianJin-Stars I returned the logic of constructing config before
https://github.com/apache/hudi/pull/8243. And just add catalog props only when
tableName is provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
