codope commented on code in PR #8508: URL: https://github.com/apache/hudi/pull/8508#discussion_r1172107083
########## website/docs/concurrency_control.md: ########## @@ -51,11 +51,22 @@ There are 4 different lock providers that require different configurations to be **`FileSystem`** based lock provider +FileSystem based lock provider supports multiple writers cross different jobs/applications based on atomic create/delete operations of the underlying filesystem. + +:::note +FileSystem based lock provider is not supported with cloud storage like S3 or GCS. +::: + ``` hoodie.write.lock.provider=org.apache.hudi.client.transaction.lock.FileSystemBasedLockProvider -hoodie.write.lock.filesystem.path +hoodie.write.lock.filesystem.path (optional) +hoodie.write.lock.filesystem.expire (optional) ``` +When using the FileSystem based lock provider, by default, the lock file will store into `hoodie.base.path`+`/.hoodie/lock`. You may use a custom folder to store the lock file by specify `hoodie.write.lock.filesystem.path`. Review Comment: Same thing at other places too. ########## website/docs/concurrency_control.md: ########## @@ -51,11 +51,22 @@ There are 4 different lock providers that require different configurations to be **`FileSystem`** based lock provider +FileSystem based lock provider supports multiple writers cross different jobs/applications based on atomic create/delete operations of the underlying filesystem. + +:::note +FileSystem based lock provider is not supported with cloud storage like S3 or GCS. +::: + ``` hoodie.write.lock.provider=org.apache.hudi.client.transaction.lock.FileSystemBasedLockProvider -hoodie.write.lock.filesystem.path +hoodie.write.lock.filesystem.path (optional) +hoodie.write.lock.filesystem.expire (optional) ``` +When using the FileSystem based lock provider, by default, the lock file will store into `hoodie.base.path`+`/.hoodie/lock`. You may use a custom folder to store the lock file by specify `hoodie.write.lock.filesystem.path`. Review Comment: ```suggestion When using the FileSystem based lock provider, by default, the lock file will store into `hoodie.base.path`+`/.hoodie/lock`. You may use a custom folder to store the lock file by specifying `hoodie.write.lock.filesystem.path`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
