danny0405 commented on code in PR #8319:
URL: https://github.com/apache/hudi/pull/8319#discussion_r1172330064
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestGcsEventsHoodieIncrSource.java:
##########
@@ -215,7 +215,7 @@ private HoodieRecord getGcsMetadataRecord(String
commitTime, String filename, St
private HoodieWriteConfig getWriteConfig() {
return getConfigBuilder(basePath(), metaClient)
-
.withArchivalConfig(HoodieArchivalConfig.newBuilder().archiveCommitsWith(2,
3).build())
+
.withArchivalConfig(HoodieArchivalConfig.newBuilder().archiveCommitsWith(4,
5).build())
.withCleanConfig(HoodieCleanConfig.newBuilder().retainCommits(1).build())
Review Comment:
Should we also tweak the min cleaning commits for MDT then. It seems there
is conflict for the data table archiving and MDT cleaning commits here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
