bvaradar commented on a change in pull request #1690:
URL: https://github.com/apache/hudi/pull/1690#discussion_r436257453
##########
File path:
hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java
##########
@@ -245,10 +245,14 @@ private static JsonToAvroFieldProcessor
generateFixedTypeHandler() {
return new JsonToAvroFieldProcessor() {
@Override
public Pair<Boolean, Object> convert(Object value, String name, Schema
schema) {
- byte[] src = value.toString().getBytes();
+ ArrayList<Integer> converval = (ArrayList<Integer>) value;
Review comment:
Thanks for the explanation. Makes sense. ObjectMapper uses List<Integer>
to represent FixedType. So, each entry in the list is within the range of
[-128, 127]. right ?
##########
File path:
hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java
##########
@@ -245,10 +245,14 @@ private static JsonToAvroFieldProcessor
generateFixedTypeHandler() {
return new JsonToAvroFieldProcessor() {
@Override
public Pair<Boolean, Object> convert(Object value, String name, Schema
schema) {
- byte[] src = value.toString().getBytes();
+ ArrayList<Integer> converval = (ArrayList<Integer>) value;
Review comment:
Minor Comment: Can you use List<Integer> instead of ArrayList<Integer>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
