yihua commented on code in PR #8319:
URL: https://github.com/apache/hudi/pull/8319#discussion_r1174213439
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestGcsEventsHoodieIncrSource.java:
##########
@@ -215,7 +215,7 @@ private HoodieRecord getGcsMetadataRecord(String
commitTime, String filename, St
private HoodieWriteConfig getWriteConfig() {
return getConfigBuilder(basePath(), metaClient)
-
.withArchivalConfig(HoodieArchivalConfig.newBuilder().archiveCommitsWith(2,
3).build())
+
.withArchivalConfig(HoodieArchivalConfig.newBuilder().archiveCommitsWith(4,
5).build())
.withCleanConfig(HoodieCleanConfig.newBuilder().retainCommits(1).build())
Review Comment:
There is no conflict in the production code, where 20 and 30 are set for min
and max commits for archival. And there's a reason to keep a few versions for
MDT from cleaning. It's only in some tests that we take shortcuts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
