yihua commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1174317642
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -245,16 +246,18 @@ public static boolean
isConsistentLogicalTimestampEnabled(Configuration conf) {
*/
public static boolean needsGuardByLock(Configuration conf) {
return conf.getBoolean(FlinkOptions.METADATA_ENABLED)
- || conf.getString(HoodieWriteConfig.WRITE_CONCURRENCY_MODE.key(),
HoodieWriteConfig.WRITE_CONCURRENCY_MODE.defaultValue())
-
.equalsIgnoreCase(WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL.value());
+ || ConfigUtils.resolveEnum(WriteConcurrencyMode.class, conf.getString(
Review Comment:
nit: we can just convert to upper case and avoid using
`ConfigUtils.resolveEnum` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
