danny0405 commented on code in PR #8546:
URL: https://github.com/apache/hudi/pull/8546#discussion_r1174732825
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java:
##########
@@ -120,6 +120,11 @@ private void commitIfNecessary(String instant,
List<ClusteringCommitEvent> event
}
if (events.stream().anyMatch(ClusteringCommitEvent::isFailed)) {
+ events.forEach(event -> {
+ if (event.isFailed()) {
+ LOG.warn("Failed clustering event from task " + event.getTaskID() +
", rollback instant " + instant);
Review Comment:
There is no need to iterate over the evens again, just do it in the anyMatch
block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
