SteNicholas commented on code in PR #8503:
URL: https://github.com/apache/hudi/pull/8503#discussion_r1175964368
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -441,6 +441,8 @@ private Stream<HoodieInstant> getCommitInstantsToArchive()
throws IOException {
Option<HoodieInstant> oldestInstantToRetainForClustering =
ClusteringUtils.getOldestInstantToRetainForClustering(table.getActiveTimeline(),
table.getMetaClient());
+ table.getIndex().updateMetadata(table);
+
Review Comment:
@rohan-uptycs, could the `updateMetadata` be invoked after archive or the
caller of `getCommitInstantsToArchive`? IMO, `getCommitInstantsToArchive` only
gets the commit instants to archive, no any update behavior. Therefore, the
`updateMetadata` should not trigger in `getCommitInstantsToArchive`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
