danny0405 commented on code in PR #8512:
URL: https://github.com/apache/hudi/pull/8512#discussion_r1176144175
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/sort/SortOperator.java:
##########
@@ -89,7 +95,7 @@ public void open() throws Exception {
binarySerializer,
computer,
comparator,
- getContainingTask().getJobConfiguration());
+ conf);
Review Comment:
I'm afraid the fix is not right, take a look at the Flink fix:
https://github.com/apache/flink/pull/22024, they fetch the options through the
planner table config which is passed around during plan generation, and here,
tha options from the catalog table does not incude any table config options
from `flink-conf.yaml` or `SqlClient` session, it's just the SQL options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
