danny0405 commented on code in PR #8556:
URL: https://github.com/apache/hudi/pull/8556#discussion_r1176701361
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/profile/WriteProfiles.java:
##########
@@ -83,95 +83,38 @@ public static void clean(String path) {
}
/**
- * Returns all the incremental write file statuses with the given commits
metadata.
+ * Returns all exist incremental write file statuses from the given commit
metadata list.
Review Comment:
Can we rollback this change.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/profile/WriteProfiles.java:
##########
@@ -83,95 +83,38 @@ public static void clean(String path) {
}
/**
- * Returns all the incremental write file statuses with the given commits
metadata.
+ * Returns all exist incremental write file statuses from the given commit
metadata list.
*
- * <p> Different with {@link #getWritePathsOfInstants}, the files are not
filtered by
- * existence.
- *
- * @param basePath Table base path
- * @param hadoopConf The hadoop conf
- * @param metadataList The commits metadata
- * @param tableType The table type
+ * @param basePath Table base path
+ * @param hadoopConf The hadoop conf
+ * @param metadataList The commit metadata list (should in ascending
order)
+ * @param tableType The table type
+ * @param tolerateNonExist Whether to tolerate non-exist file, when is false
and have non-exist file return null
* @return the file status array
Review Comment:
tolerateNonExist -> ignoreMissingFiles Whether to ignore the missing files
from filesystem
@return the file status array or null if any file is missing if
ignoreMissingFiles is false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
