garyli1019 commented on a change in pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#discussion_r436467598
##########
File path: hudi-client/src/test/java/org/apache/hudi/client/TestMultiFS.java
##########
@@ -63,9 +63,7 @@ public void setUp() throws Exception {
@AfterEach
public void tearDown() throws Exception {
- cleanupSparkContexts();
- cleanupDFS();
- cleanupTestDataGenerator();
+ cleanupResources();
Review comment:
We didn't miss one yet but it's easy to miss, so I put all the clean up
in one place.
The leak I found was `HoodieLogFileReader` and `HoodieWrapperFileSystem`.
These instances were created from different classes and difficult to clean up.
By setting `Xmx2g` is consuming less memory than `Xmx4g`, probably because
of the more aggressive GC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
