bvaradar commented on code in PR #8143:
URL: https://github.com/apache/hudi/pull/8143#discussion_r1181169082
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/DirectMarkerTransactionManager.java:
##########
@@ -83,7 +83,7 @@ private static TypedProperties createUpdatedLockProps(
throw new HoodieNotSupportedException("Only Support ZK-based lock for
DirectMarkerTransactionManager now.");
}
TypedProperties props = new TypedProperties(writeConfig.getProps());
- props.setProperty(LockConfiguration.ZK_LOCK_KEY_PROP_KEY, partitionPath +
"/" + fileId);
+ props.setProperty(LockConfiguration.ZK_LOCK_KEY_PROP_KEY, (null !=
partitionPath && !partitionPath.isEmpty()) ? partitionPath + "/" + fileId :
fileId);
Review Comment:
This change will pose a challenge when upgrading. During upgrade, we would
need all writers to be stopped and upgrade to the version containing this
change for safe concurrency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
