codope commented on code in PR #8558:
URL: https://github.com/apache/hudi/pull/8558#discussion_r1175373114
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieStreamingSink.scala:
##########
@@ -350,26 +322,8 @@ class HoodieStreamingSink(sqlContext: SQLContext,
}
}
-/**
- * SINK_CHECKPOINT_KEY holds a map of batchId to writer context (composed of
applicationId and queryId).
- * This is a util object to serialize/deserialize map to/from json.
- */
-object HoodieSinkCheckpoint {
-
- lazy val mapper: ObjectMapper = {
- val _mapper = JsonUtils.getObjectMapper
- _mapper.registerModule(DefaultScalaModule)
- _mapper
- }
+object HoodieStreamingSink {
// This constant serves as the checkpoint key for streaming sink so that
each microbatch is processed exactly-once.
val SINK_CHECKPOINT_KEY = "_hudi_streaming_sink_checkpoint"
Review Comment:
Does it make sense to remove this object now? It's just holding a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
