boneanxs commented on code in PR #7627:
URL: https://github.com/apache/hudi/pull/7627#discussion_r1184488167
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieStreamSource.scala:
##########
@@ -163,10 +178,7 @@ class HoodieStreamSource(
startOffset match {
case INIT_OFFSET => startOffset.commitTime
case HoodieSourceOffset(commitTime) =>
- val time =
HoodieActiveTimeline.parseDateFromInstantTime(commitTime).getTime
Review Comment:
I think this is unnecessary, since we filter all instants in
`IncrementalRelation` and `MergeOnReadIncrementalRelation` by methods
`findInstantsInRangeByStateTransitionTs` and `findInstantsInRange`, these two
methods filter instants after startTs and before or on endTs.
```java
/**
* Create a new Timeline with instants after startTs and before or on
endTs.
*/
HoodieTimeline findInstantsInRange(String startTs, String endTs);
/**`
* Create a new Timeline with instants after startTs and before or on endTs
* by state transition timestamp of actions.
*/
HoodieTimeline findInstantsInRangeByStateTransitionTs(String startTs,
String endTs);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
