CTTY commented on code in PR #8190:
URL: https://github.com/apache/hudi/pull/8190#discussion_r1185501702
##########
hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java:
##########
@@ -106,9 +106,9 @@ private List<String> getPartitionPathWithPathPrefix(String
relativePathPrefix) t
int listingParallelism = Math.min(DEFAULT_LISTING_PARALLELISM,
pathsToList.size());
// List all directories in parallel
- List<FileStatus> dirToFileListing = engineContext.flatMap(pathsToList,
path -> {
+ List<Pair<Path, Boolean>> dirToFileListing =
engineContext.flatMap(pathsToList, path -> {
FileSystem fileSystem = path.getFileSystem(hadoopConf.get());
- return Arrays.stream(fileSystem.listStatus(path));
+ return Arrays.stream(fileSystem.listStatus(path)).map(fileStatus ->
Pair.of(fileStatus.getPath(), fileStatus.isDirectory()));
}, listingParallelism);
Review Comment:
Java default serialization here should be sufficient. But could you help me
learn what's the benefit of having custom SE/DE here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
