nsivabalan commented on code in PR #8599:
URL: https://github.com/apache/hudi/pull/8599#discussion_r1185542046
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2175,7 +2175,8 @@ public boolean getPushGatewayRandomJobNameSuffix() {
}
public String getMetricReporterMetricsNamePrefix() {
- return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX);
+ // Metrics prefixes should not have a dot as this is usually a separator
+ return
getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX).replaceAll("\\.",
"_");
Review Comment:
I see why we do this. If the metrics prefix has "." (dots), it might cause
issues w/ dashbaords. So, may be not a bad idea. but it might break someone who
was using it so far (by mistake)
@rmahindra123 @harsh1231 : do you folks have any thoughts here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
