harsh1231 commented on code in PR #8520: URL: https://github.com/apache/hudi/pull/8520#discussion_r1185684016
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/ErrorTableUtils.java: ########## @@ -28,32 +28,39 @@ import org.apache.hudi.exception.HoodieException; import org.apache.hadoop.fs.FileSystem; +import org.apache.hudi.exception.HoodieValidationException; import org.apache.spark.api.java.JavaSparkContext; +import org.apache.spark.sql.Dataset; +import org.apache.spark.sql.Row; import org.apache.spark.sql.SparkSession; +import static org.apache.spark.sql.functions.lit; + import java.lang.reflect.InvocationTargetException; import java.util.Arrays; +import java.util.stream.Collectors; import static org.apache.hudi.config.HoodieErrorTableConfig.ERROR_TABLE_WRITE_CLASS; import static org.apache.hudi.config.HoodieErrorTableConfig.ERROR_TABLE_WRITE_FAILURE_STRATEGY; +import static org.apache.hudi.utilities.deltastreamer.BaseErrorTableWriter.ERROR_TABLE_CURRUPT_RECORD_COL_NAME; Review Comment: `_corrupt_record ` this column is intermediate state , it's never commited to base table as column . before commiting error table , we separate out valid / error events and drop this column . https://issues.apache.org/jira/browse/HUDI-6181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
