danny0405 commented on code in PR #8107: URL: https://github.com/apache/hudi/pull/8107#discussion_r1185814578
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/AutoRecordGenWrapperAvroKeyGenerator.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.keygen; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.model.HoodieRecord; + +import org.apache.avro.generic.GenericRecord; + +import java.util.List; +import java.util.concurrent.atomic.AtomicBoolean; + +/** + * A wrapper key generator to intercept getRecordKey calls for auto record key generator. + * <ol> + * <li>Generated keys will be unique not only w/in provided [[org.apache.spark.sql.DataFrame]], but + * globally unique w/in the target table</li> + * <li>Generated keys have minimal overhead (to compute, persist and read)</li> + * </ol> + * + * Keys adhere to the following format: + * + * [instantTime]_[PartitionId]_[RowId] + * + * where + * instantTime refers to the commit time of the batch being ingested. + * PartitionId refers to spark's partition Id. + * RowId refers to the row index within the spark partition. + */ +public class AutoRecordGenWrapperAvroKeyGenerator extends BaseKeyGenerator { + + private final BaseKeyGenerator keyGenerator; + private final AtomicBoolean initializeAutoKeyGenProps = new AtomicBoolean(false); + private int partitionId; + private String instantTime; + private int rowId; + + public AutoRecordGenWrapperAvroKeyGenerator(TypedProperties config, BaseKeyGenerator keyGenerator) { + super(config); + this.keyGenerator = keyGenerator; + } + + @Override + public String getRecordKey(GenericRecord record) { + initializeAutoKeyGenProps(); + return HoodieRecord.generateSequenceId(instantTime, partitionId, rowId++); + } + + private void initializeAutoKeyGenProps() { + if (!initializeAutoKeyGenProps.getAndSet(true)) { + this.rowId = 0; + this.partitionId = config.getInteger(KeyGenUtils.RECORD_KEY_GEN_PARTITION_ID_CONFIG); Review Comment: Can the init code be moved to the constructor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
