danny0405 commented on code in PR #8505:
URL: https://github.com/apache/hudi/pull/8505#discussion_r1185884599
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java:
##########
@@ -269,13 +272,14 @@ private int doCompact(JavaSparkContext jsc) throws
Exception {
}
}
HoodieWriteMetadata<JavaRDD<WriteStatus>> compactionMetadata =
client.compact(cfg.compactionInstantTime);
+ cleanAfterCompact(client);
return
UtilHelpers.handleErrors(compactionMetadata.getCommitMetadata().get(),
cfg.compactionInstantTime);
}
}
private Option<String> doSchedule(JavaSparkContext jsc) {
try (SparkRDDWriteClient client =
- UtilHelpers.createHoodieClient(jsc, cfg.basePath, "",
cfg.parallelism, Option.of(cfg.strategyClassName), props)) {
+ UtilHelpers.createHoodieClient(jsc, cfg.basePath, "",
cfg.parallelism, Option.of(cfg.strategyClassName), props,
cfg.asyncSerivceEanble)) {
if (StringUtils.isNullOrEmpty(cfg.compactionInstantTime)) {
LOG.warn("No instant time is provided for scheduling compaction.");
Review Comment:
Why cann't we just set the props correctly first? Then there is no need to
define another new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
