yihua commented on code in PR #8557:
URL: https://github.com/apache/hudi/pull/8557#discussion_r1186752187
##########
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/cli/BootstrapExecutorUtils.java:
##########
@@ -263,10 +262,9 @@ private void initializeTable() throws IOException {
private Pair<String, String> genKeyGenClassAndPartitionColumns() {
String keyGenClass;
- if
(StringUtils.nonEmpty(props.getString(HoodieBootstrapConfig.KEYGEN_CLASS_NAME.key(),
null))) {
- keyGenClass =
props.getString(HoodieBootstrapConfig.KEYGEN_CLASS_NAME.key());
- } else if
(StringUtils.nonEmpty(props.getString(HoodieBootstrapConfig.KEYGEN_TYPE.key(),
null))) {
- props.put(HoodieWriteConfig.KEYGENERATOR_TYPE.key(),
props.getString(HoodieBootstrapConfig.KEYGEN_TYPE.key()));
+ if
(StringUtils.nonEmpty(props.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key(),
null))) {
Review Comment:
Since the bootstrap operation is an one-time operation, it is ok to ask user
to use new configs and we'll mention in the docs that the old configs are
removed. Also, in common use cases where simple keygen is used, such a config
is not required.
##########
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/cli/BootstrapExecutorUtils.java:
##########
@@ -263,10 +262,9 @@ private void initializeTable() throws IOException {
private Pair<String, String> genKeyGenClassAndPartitionColumns() {
String keyGenClass;
- if
(StringUtils.nonEmpty(props.getString(HoodieBootstrapConfig.KEYGEN_CLASS_NAME.key(),
null))) {
- keyGenClass =
props.getString(HoodieBootstrapConfig.KEYGEN_CLASS_NAME.key());
- } else if
(StringUtils.nonEmpty(props.getString(HoodieBootstrapConfig.KEYGEN_TYPE.key(),
null))) {
- props.put(HoodieWriteConfig.KEYGENERATOR_TYPE.key(),
props.getString(HoodieBootstrapConfig.KEYGEN_TYPE.key()));
+ if
(StringUtils.nonEmpty(props.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key(),
null))) {
Review Comment:
Since the bootstrap operation is a one-time operation, it is ok to ask the
user to use new configs and we'll mention in the docs that the old configs are
removed. Also, in common use cases where simple keygen is used, such a config
is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
