ad1happy2go commented on code in PR #8573:
URL: https://github.com/apache/hudi/pull/8573#discussion_r1187370581
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java:
##########
@@ -157,10 +157,10 @@ public HoodieRecord truncateRecordKey(Schema
recordSchema, Properties props, Str
@Override
public boolean isDelete(Schema recordSchema, Properties props) throws
IOException {
- if (this.data instanceof BaseAvroPayload) {
- return ((BaseAvroPayload) this.data).isDeleted(recordSchema, props);
- } else {
+ if (this.data instanceof AWSDmsAvroPayload || !(this.data instanceof
BaseAvroPayload)) {
Review Comment:
Updated the logic as per suggestion. It should be AND logic instead of OR.
Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
