xushiyan commented on code in PR #8573:
URL: https://github.com/apache/hudi/pull/8573#discussion_r1189898555
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java:
##########
@@ -157,7 +157,7 @@ public HoodieRecord truncateRecordKey(Schema recordSchema,
Properties props, Str
@Override
public boolean isDelete(Schema recordSchema, Properties props) throws
IOException {
- if (this.data instanceof BaseAvroPayload) {
+ if (this.data instanceof BaseAvroPayload && !(this.data instanceof
AWSDmsAvroPayload)) {
Review Comment:
we should avoid making base class dependent on subclass. Besides, the issue
rooted at custom delete marker, which `DefaultHoodieRecordPayload` uses and
gets affected by this too. So this won't resolve for
`DefaultHoodieRecordPayload` and subclasses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
