voonhous opened a new pull request, #8687: URL: https://github.com/apache/hudi/pull/8687
…ableConfig before using it In [8653](https://github.com/apache/hudi/issues/8653) we found that there are some write paths that will create tables without the `hoodie.datasource.write.hive_style_partitioning` in `hoodie.properties`. Hence, it is unsafe to blindly assume the default value of `hoodie.datasource.write.hive_style_partitioning` when invoking `SparkHoodieTableFileIndex#composeRelativePartitionPath()`. If an assumption is used here, the method runs the risk of constructing a partitionPath that does not exists as it is in might be in the wrong format. This is so as `BaseHoodieTableFileIndex#listPartitionPaths()` will attempt to create partitions when a partition path that does not exist is passed to it. As such, this ticket is to add a validation-check to prevent `hoodie.datasource.write.hive_style_partitioning` from being used in an unsafe manner. ### Change Logs Validate that `hoodie.datasource.write.hive_style_partitioning` is in `hoodie.properties` before using it. ### Impact None _Describe any public API or user-facing feature change or any performance impact._ ### Risk level (write none, low medium or high below) Low _If medium or high, explain what verification was done to mitigate the risks._ ### Documentation Update _Describe any necessary documentation update if there is any new feature, config, or user-facing change_ - _The config description must be updated if new configs are added or the default value of the configs are changed_ - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website._ ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [ ] Change Logs and Impact were stated clearly - [ ] Adequate tests were added if applicable - [ ] CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
