xushiyan commented on code in PR #8690:
URL: https://github.com/apache/hudi/pull/8690#discussion_r1193713591
##########
hudi-common/src/main/java/org/apache/hudi/common/model/debezium/AbstractDebeziumAvroPayload.java:
##########
@@ -91,4 +91,14 @@ private Option<IndexedRecord>
handleDeleteOperation(IndexedRecord insertRecord)
private Option<IndexedRecord> getInsertRecord(Schema schema) throws
IOException {
return super.getInsertValue(schema);
}
+
+ @Override
+ protected boolean isDeleteRecord(GenericRecord record) {
+ return isDebeziumDeleteRecord(record) || super.isDeleteRecord(record);
+ }
+
+ private boolean isDebeziumDeleteRecord(GenericRecord record) {
Review Comment:
can be static too
##########
hudi-common/src/main/java/org/apache/hudi/common/model/AWSDmsAvroPayload.java:
##########
@@ -94,4 +94,13 @@ public Option<IndexedRecord>
combineAndGetUpdateValue(IndexedRecord currentValue
}
return handleDeleteOperation(insertValue.get());
}
+
+ @Override
+ protected boolean isDeleteRecord(GenericRecord record) {
+ return isDMSDeleteRecord(record) || super.isDeleteRecord(record);
+ }
+
+ private boolean isDMSDeleteRecord(GenericRecord record) {
Review Comment:
this can be static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
