leesf commented on code in PR #8722:
URL: https://github.com/apache/hudi/pull/8722#discussion_r1195145768
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -609,36 +609,64 @@ public void savepoint(String user, String comment) {
* <p>
* Savepoint should be on a commit that could not have been cleaned.
*
- * @param instantTime - commit that should be savepointed
- * @param user - User creating the savepoint
- * @param comment - Comment for the savepoint
+ * @param instantTime Commit that should be savepointed
+ * @param user User creating the savepoint
+ * @param comment Comment for the savepoint
*/
public void savepoint(String instantTime, String user, String comment) {
HoodieTable<T, I, K, O> table = createTable(config, hadoopConf);
table.savepoint(context, instantTime, user, comment);
}
+ /**
+ * Delete a savepoint based on the latest commit action on the savepoint
timeline.
+ */
+ public void deleteSavepoint() {
+ HoodieTable<T, I, K, O> table = createTable(config, hadoopConf);
+ HoodieTimeline savePointTimeline =
table.getActiveTimeline().getSavePointTimeline();
+ if (savePointTimeline.empty()) {
+ throw new HoodieSavepointException("Could not savepoint. Commit timeline
is empty");
+ }
+
+ String savepointTime =
savePointTimeline.lastInstant().get().getTimestamp();
+ LOG.info("Deleting latest savepoint time " + savepointTime);
+ deleteSavepoint(savepointTime);
+ }
+
/**
* Delete a savepoint that was created. Once the savepoint is deleted, the
commit can be rolledback and cleaner may
* clean up data files.
*
- * @param savepointTime - delete the savepoint
- * @return true if the savepoint was deleted successfully
+ * @param savepointTime Savepoint time to delete
*/
public void deleteSavepoint(String savepointTime) {
HoodieTable<T, I, K, O> table = createTable(config, hadoopConf);
SavepointHelpers.deleteSavepoint(table, savepointTime);
}
+ /**
+ * Restore the data to a savepoint based on the latest commit action on the
savepoint timeline.
+ */
+ public void restoreToSavepoint() {
+ HoodieTable<T, I, K, O> table = createTable(config, hadoopConf);
+ HoodieTimeline savePointTimeline =
table.getActiveTimeline().getSavePointTimeline();
+ if (savePointTimeline.empty()) {
+ throw new HoodieSavepointException("Could not savepoint. Commit timeline
is empty");
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
