Litianye commented on pull request #1719: URL: https://github.com/apache/hudi/pull/1719#issuecomment-642395107
> I think we can replace empty string by `Option.empty()` https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java#L261 > so we only needs to handle one case later. This will make the logic more straight forward. WDYT? but afraid of empty string has a special meaning in other kind of `Source`, i only use `KafkaSource` before. :no_mouth: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
