danny0405 commented on code in PR #8747:
URL: https://github.com/apache/hudi/pull/8747#discussion_r1197616329
##########
hudi-spark-datasource/hudi-spark3.1.x/src/main/scala/org/apache/spark/sql/hudi/command/Spark31AlterTableCommand.scala:
##########
@@ -298,18 +296,6 @@ object Spark31AlterTableCommand extends Logging {
} else ""
}
- def parametersWithWriteDefaults(parameters: Map[String, String]):
Map[String, String] = {
- Map(OPERATION.key -> OPERATION.defaultValue,
- TABLE_TYPE.key -> TABLE_TYPE.defaultValue,
- PRECOMBINE_FIELD.key -> PRECOMBINE_FIELD.defaultValue,
- HoodieWriteConfig.WRITE_PAYLOAD_CLASS_NAME.key ->
HoodieWriteConfig.DEFAULT_WRITE_PAYLOAD_CLASS,
- INSERT_DROP_DUPS.key -> INSERT_DROP_DUPS.defaultValue,
Review Comment:
We may also need to fix the datasource options to sql options mappings:
https://github.com/apache/hudi/pull/8710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
