vinothchandar commented on a change in pull request #1727:
URL: https://github.com/apache/hudi/pull/1727#discussion_r438953612



##########
File path: 
hudi-client/hudi-client-spark/src/main/java/org/apache/hudi/client/SparkCompactionAdminClient.java
##########
@@ -0,0 +1,131 @@
+package org.apache.hudi.client;
+
+import org.apache.hudi.avro.model.HoodieCompactionPlan;
+import org.apache.hudi.client.embedded.SparkEmbeddedTimelineService;
+import org.apache.hudi.common.HoodieEngineContext;
+import org.apache.hudi.common.HoodieSparkEngineContext;
+import org.apache.hudi.common.model.CompactionOperation;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.view.HoodieTableFileSystemView;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.spark.api.java.JavaSparkContext;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
+public class SparkCompactionAdminClient extends AbstractCompactionAdminClient {
+  private static final Logger LOG = 
LoggerFactory.getLogger(SparkCompactionAdminClient.class);
+
+  public SparkCompactionAdminClient(HoodieEngineContext context, String 
basePath) {
+    super(context, basePath);
+  }
+
+  @Override
+  public List<ValidationOpResult> validateCompactionPlan(HoodieTableMetaClient 
metaClient, String compactionInstant, int parallelism) throws IOException {
+    JavaSparkContext jsc = ((HoodieSparkEngineContext) 
context).getJavaSparkContext();

Review comment:
       pull this into a helper like 
`HoodieSparkEngineContext.getSparkContext(engineCtx)` ? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to