[hudi] branch master updated: [MINOR] Optimize code style (#8751)

[yihua]

This is an automated email from the ASF dual-hosted git repository.

yihua pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new dcc1a07dcfe [MINOR] Optimize code style (#8751)
dcc1a07dcfe is described below

commit dcc1a07dcfed3062d2a932ed37e449b69fc3739c
Author: 青木长风 <42636497+boundarym...@users.noreply.github.com>
AuthorDate: Tue May 23 14:29:36 2023 +0800

    [MINOR] Optimize code style (#8751)
---
 .../org/apache/hudi/client/BaseHoodieTableServiceClient.java     | 9 ++++-----
 .../main/java/org/apache/hudi/client/BaseHoodieWriteClient.java  | 2 +-
 .../hudi/common/table/view/AbstractTableFileSystemView.java      | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git 
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java
 
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java
index 70aadf65a36..a2543957fa7 100644
--- 
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java
+++ 
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java
@@ -205,7 +205,7 @@ public abstract class BaseHoodieTableServiceClient<O> 
extends BaseHoodieClient i
         });
   }
 
-  /***
+  /**
    * Schedules compaction inline.
    * @param extraMetadata extra metadata to be used.
    * @return compaction instant if scheduled.
@@ -645,18 +645,17 @@ public abstract class BaseHoodieTableServiceClient<O> 
extends BaseHoodieClient i
 
       try {
         String action = rollbackPlan.getInstantToRollback().getAction();
+        String instantToRollback = 
rollbackPlan.getInstantToRollback().getCommitTime();
         if (ignoreCompactionAndClusteringInstants) {
           if (!HoodieTimeline.COMPACTION_ACTION.equals(action)) {
             boolean isClustering = 
HoodieTimeline.REPLACE_COMMIT_ACTION.equals(action)
-                && ClusteringUtils.getClusteringPlan(metaClient, new 
HoodieInstant(true, rollbackPlan.getInstantToRollback().getAction(),
-                
rollbackPlan.getInstantToRollback().getCommitTime())).isPresent();
+                && ClusteringUtils.getClusteringPlan(metaClient, new 
HoodieInstant(true, action, instantToRollback)).isPresent();
             if (!isClustering) {
-              String instantToRollback = 
rollbackPlan.getInstantToRollback().getCommitTime();
               infoMap.putIfAbsent(instantToRollback, Option.of(new 
HoodiePendingRollbackInfo(rollbackInstant, rollbackPlan)));
             }
           }
         } else {
-          
infoMap.putIfAbsent(rollbackPlan.getInstantToRollback().getCommitTime(), 
Option.of(new HoodiePendingRollbackInfo(rollbackInstant, rollbackPlan)));
+          infoMap.putIfAbsent(instantToRollback, Option.of(new 
HoodiePendingRollbackInfo(rollbackInstant, rollbackPlan)));
         }
       } catch (Exception e) {
         LOG.warn("Processing rollback plan failed for " + rollbackInstant + ", 
skip the plan", e);
diff --git 
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
 
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
index 2806d0d4c0f..7f39cf41d75 100644
--- 
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
+++ 
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
@@ -1057,7 +1057,7 @@ public abstract class BaseHoodieWriteClient<T, I, K, O> 
extends BaseHoodieClient
    */
   protected abstract HoodieWriteMetadata<O> compact(String 
compactionInstantTime, boolean shouldComplete);
 
-  /***
+  /**
    * Schedules compaction inline.
    * @param extraMetadata extra metadata to be used.
    * @return compaction instant if scheduled.
diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
index c2c0fa4b792..0279be560aa 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
@@ -374,7 +374,7 @@ public abstract class AbstractTableFileSystemView 
implements SyncableFileSystemV
     }
   }
 
-  /***
+  /**
    * @return A list of relative partition paths of all partitions.
    * @throws IOException upon error.
    */