danny0405 commented on code in PR #8478:
URL: https://github.com/apache/hudi/pull/8478#discussion_r1201809476
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HiveSchemaUtil.java:
##########
@@ -446,58 +448,76 @@ public static String generateSchemaString(MessageType
storageSchema, List<String
return generateSchemaString(storageSchema, colsToSkip, false);
}
- public static String generateSchemaString(MessageType storageSchema,
List<String> colsToSkip, boolean supportTimestamp) throws IOException {
+ /**
+ * Generates the Column DDL string for creating a Hive table from the given
schema.
Review Comment:
I love the original document that we add a SQL statement demo for the
method, can we keep that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
