danny0405 commented on code in PR #8605:
URL: https://github.com/apache/hudi/pull/8605#discussion_r1203490569
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -388,12 +388,23 @@ public boolean containsInstant(HoodieInstant instant) {
@Override
public boolean containsInstant(String ts) {
- return getInstantsAsStream().anyMatch(s -> s.getTimestamp().equals(ts));
+ // Check for 0.10.0+ timestamps which have msec granularity
+ if (getInstantsAsStream().anyMatch(s -> s.getTimestamp().equals(ts))) {
+ return true;
+ }
+
+ // Check for older timestamp which have sec granularity and an extension
of DEFAULT_MILLIS_EXT may have been added via Timeline operations
+ if (ts.length() ==
HoodieInstantTimeGenerator.MILLIS_INSTANT_TIMESTAMP_FORMAT_LENGTH &&
ts.endsWith(HoodieInstantTimeGenerator.DEFAULT_MILLIS_EXT)) {
+ final String actualOlderFormatTs = ts.substring(0, ts.length() -
HoodieInstantTimeGenerator.DEFAULT_MILLIS_EXT.length());
+ return containsOrBeforeTimelineStarts(actualOlderFormatTs);
+ }
+
+ return false;
}
@Override
public boolean containsOrBeforeTimelineStarts(String instant) {
- return getInstantsAsStream().anyMatch(s ->
s.getTimestamp().equals(instant)) || isBeforeTimelineStarts(instant);
+ return containsInstant(instant) || isBeforeTimelineStarts(instant);
Review Comment:
Nice catch ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
