danny0405 commented on code in PR #8797:
URL: https://github.com/apache/hudi/pull/8797#discussion_r1206186838
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/HoodieCompactor.java:
##########
@@ -247,6 +256,17 @@ public List<WriteStatus> compact(HoodieCompactionHandler
compactionHandler,
}).collect(toList());
}
+ private InstantRange getMetadataLogReaderInstantRange(HoodieTableMetaClient
metadataMetaClient, String metadataBasePath) {
Review Comment:
> Is there any case where C2's log file in MDT is kept for later and it
will be missed in MDT, since it's in the old file slice?
Good question, the log would then be removed by the MDT cleaner ? So it
would not be kept forever. When new rollback commit for C2 from data table is
committed into MDT again, there could be some tumestone records there which
would be ignored (by default allowed by master codebase).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
