amrishlal commented on PR #8759: URL: https://github.com/apache/hudi/pull/8759#issuecomment-1564812644
> @amrishlal, you could follow `TestHoodieMetrics` to verify the introduced metrics. PTAL. > cc @nsivabalan @SteNicholas From what I can see, `TestHoodieMetrics` is testing `HoodieMetrics` class, but not any production metric values such as `counter.compaction.completed`. Same with classes such as `TestHoodieConsoleMetrics` and `TestHoodieJmxMetrics` etc. Allowing for testing production metrics values in unit test is a good idea, but would need some structural changes to `HoodieMetrics` class (exposing methods to test classes etc to allow for accessing metrics value) which I am hesitant to do as part of this PR since such changes are not directly related. I can put out another PR to allow for testing production metrics in unit tests. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
