suryaprasanna commented on PR #8783: URL: https://github.com/apache/hudi/pull/8783#issuecomment-1565954203
The bug where reader's are reading from inflight instant is resolved. With this change, I am trying to consolidate the approach of handling inflight commits. Since, we are handling pending compaction and replacecommits separately and it could lead to various corner cases. For example, when cleaner's earliestToRetain can cross the inflight instant and when this inflight file is committed, we will have different versions of the files left in the partitions. These kind of various cases can play out. So, I was thinking we need to have similar logic for both archival and cleaner. So, if there is a inflight commit present then both the archival and cleaner cannot cross the largestCompletedInstant i.e. < oldestInflighiInstant. We can say cleaner's earliestCommitToRetain similarly archival's max instant to archive cannot cross this commit. That is why I am trying to keep largestCompletedInstant that is less than the oldestInflightinstant from getting archived. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
