danny0405 commented on code in PR #8807: URL: https://github.com/apache/hudi/pull/8807#discussion_r1208831589
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/ConfigurationHotUpdateStrategyUtils.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.deltastreamer; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.ReflectionUtils; +import org.apache.hudi.common.util.StringUtils; +import org.apache.hudi.exception.HoodieException; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.HashSet; +import java.util.Map; +import java.util.Set; + +public class ConfigurationHotUpdateStrategyUtils { + private static final Logger LOG = LoggerFactory.getLogger(ConfigurationHotUpdateStrategyUtils.class); + + /** + * Create a ConfigurationHotUpdateStrategy class via reflection, + * <br> + * if the class name of ConfigurationHotUpdateStrategy is configured through the {@link HoodieDeltaStreamer.Config#configHotUpdateStrategyClass}. + */ + public static Option<ConfigurationHotUpdateStrategy> createConfigurationHotUpdateStrategy(String configHotUpdateStrategyClass, + HoodieDeltaStreamer.Config cfg, + TypedProperties properties) + throws HoodieException { + try { + return StringUtils.isNullOrEmpty(configHotUpdateStrategyClass) + ? Option.empty() : + Option.of((ConfigurationHotUpdateStrategy) ReflectionUtils.loadClass(configHotUpdateStrategyClass, cfg, properties)); + } catch (Throwable e) { + throw new HoodieException("Could not create ConfigurationHotUpdateStrategy class " + configHotUpdateStrategyClass, e); + } + } + + /** + * merge newProps to propsToUpdated. + * @param propsToUpdate the old properties to be updated in place Review Comment: merge newProps to propsToUpdated. -> ```java Returns a new config properties if original props {@code propsToUpdate} is updated with new options {@code newProps}, or original props directly if there is no change in any options. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
