SteNicholas commented on code in PR #8829:
URL: https://github.com/apache/hudi/pull/8829#discussion_r1209309363
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java:
##########
@@ -274,6 +274,17 @@ String getMetricsName(String action, String metric) {
return config == null ? null : String.format("%s.%s.%s",
config.getMetricReporterMetricsNamePrefix(), action, metric);
}
+ public void updateClusteringFileCreationMetrics(long durationInMs) {
+ metrics.registerGauge(getMetricsName("replacecommit", "fileCreationTime"),
durationInMs);
+ }
+
+ /**
+ * Given a commit action, metrics name and value this method publishes
custom metrics.
+ */
+ public void publishMetrics(String commitAction, String metricsName, long
value) {
Review Comment:
```suggestion
public void reportMetric(String commitAction, String metricName, long
value) {
```
Adds the comment of params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
