luoyajun526 commented on a change in pull request #1720:
URL: https://github.com/apache/hudi/pull/1720#discussion_r439832501
##########
File path:
hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
##########
@@ -457,6 +457,37 @@ public void testMultiPartitionKeySync(boolean useJdbc)
throws Exception {
"The last commit that was sycned should be updated in the
TBLPROPERTIES");
}
+ @ParameterizedTest
+ @MethodSource("useJdbc")
+ public void testNonPartitionedSync(boolean useJdbc) throws Exception {
+ HiveTestUtil.hiveSyncConfig.useJdbc = useJdbc;
+ String instantTime = "100";
+ HiveTestUtil.createCOWTable(instantTime, 5, true);
+
+ HiveSyncConfig hiveSyncConfig =
HiveSyncConfig.copy(HiveTestUtil.hiveSyncConfig);
+ // Set partition value extractor to NonPartitionedExtractor
+ hiveSyncConfig.partitionValueExtractorClass =
NonPartitionedExtractor.class.getCanonicalName();
+ hiveSyncConfig.tableName = "non_partitioned";
+ hiveSyncConfig.partitionFields = Arrays.asList("year", "month", "day");
+ HiveTestUtil.getCreatedTablesSet().add(hiveSyncConfig.databaseName + "." +
hiveSyncConfig.tableName);
+
+ HoodieHiveClient hiveClient = new HoodieHiveClient(hiveSyncConfig,
HiveTestUtil.getHiveConf(), HiveTestUtil.fileSystem);
+ assertFalse(hiveClient.doesTableExist(hiveSyncConfig.tableName),
+ "Table " + hiveSyncConfig.tableName + " should not exist
initially");
+ // Lets do the sync
+ HiveSyncTool tool = new HiveSyncTool(hiveSyncConfig,
HiveTestUtil.getHiveConf(), HiveTestUtil.fileSystem);
+ tool.syncHoodieTable();
+ assertTrue(hiveClient.doesTableExist(hiveSyncConfig.tableName),
+ "Table " + hiveSyncConfig.tableName + " should exist after sync
completes");
+ assertEquals(hiveClient.getTableSchema(hiveSyncConfig.tableName).size(),
+ hiveClient.getDataSchema().getColumns().size(),
+ "Hive Schema should match the table schema，ignoring the partition
fields");
+ assertEquals(0,
hiveClient.scanTablePartitions(hiveSyncConfig.tableName).size(),
+ "Table should not have partitions because of the
NonPartitionedExtractor");
+ assertEquals(0,
hiveClient.getTablePartitionKeys(hiveSyncConfig.tableName).size(),
+ "Table should not have partition keys because of the
NonPartitionedExtractor");
Review comment:
Yes we do not need it indeed. Done. Thanks for your review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
