yihua commented on code in PR #8795:
URL: https://github.com/apache/hudi/pull/8795#discussion_r1210874330
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java:
##########
@@ -190,6 +190,8 @@ protected void doSync() {
syncHoodieTable(roTableName.get(), false, true);
// sync a RT table for MOR
syncHoodieTable(snapshotTableName, true, false);
+ // sync origin table for MOR
+ syncHoodieTable(tableName, true, false);
Review Comment:
This can collide with the RO table if the `_ro` suffix is skipped for Hive
sync. Could you add a feature flag around the new sync logic?
```
this.roTableName =
config.getBoolean(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)
? Option.of(tableName)
: Option.of(tableName + SUFFIX_READ_OPTIMIZED_TABLE);
```
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java:
##########
@@ -190,6 +190,8 @@ protected void doSync() {
syncHoodieTable(roTableName.get(), false, true);
// sync a RT table for MOR
syncHoodieTable(snapshotTableName, true, false);
+ // sync origin table for MOR
+ syncHoodieTable(tableName, true, false);
Review Comment:
Also, can OLAP engine like MySQL query a MOR table with log files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
